Notebook Renderer: make formSchemaRegistry a required property#918
Merged
martinRenou merged 2 commits intogeojupyter:mainfrom Sep 5, 2025
Merged
Notebook Renderer: make formSchemaRegistry a required property#918martinRenou merged 2 commits intogeojupyter:mainfrom
formSchemaRegistry a required property#918martinRenou merged 2 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
arjxn-py
changed the title
formSchemaRegistry a required property
Contributor
|
Integration tests report: appsharing.space |
Member
|
This makes no sense to me that the code change fixes the issue, the plugin should be there so it should be loaded. But it does fix it: 
I'm wondering if there isn't a Lumino plugin activation issue laying around. Anyway it seems it's not so optional so making it required is safer, we should probably be more restrictive on these and mark "required" everything we do need |
martinRenou
approved these changes
Sep 5, 2025
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
…jupyter#918) * Notebook Renderer: make formSchemaRegistry a required property * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #916
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--918.org.readthedocs.build/en/918/
💡 JupyterLite preview: https://jupytergis--918.org.readthedocs.build/en/918/lite